rohangarg commented on a change in pull request #12127:
URL: https://github.com/apache/druid/pull/12127#discussion_r781924975



##########
File path: 
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidJoinQueryRel.java
##########
@@ -163,6 +163,9 @@ public DruidQuery toDruidQuery(final boolean 
finalizeAggregations)
 
     final Pair<String, RowSignature> prefixSignaturePair = 
computeJoinRowSignature(leftSignature, rightSignature);
 
+    VirtualColumnRegistry virtualColumnRegistry = 
VirtualColumnRegistry.create(prefixSignaturePair.rhs);
+    getPlannerContext().setVirtualColumnRegistry(virtualColumnRegistry);

Review comment:
       not a problem with the new changes to pass VC registry in the 
constructor itself




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to