pjain1 commented on a change in pull request #11309:
URL: https://github.com/apache/druid/pull/11309#discussion_r832556435
##########
File path:
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java
##########
@@ -436,6 +453,58 @@ public void cleanup(DataSegment segment)
}
}
+ @Override
+ public void loadSegmentIntoPageCache(DataSegment segment, ExecutorService
exec)
+ {
+ ExecutorService execToUse = exec != null ? exec :
loadSegmentsIntoPageCacheOnDownloadExec;
+ if (execToUse == null) {
+ return;
+ }
+
+ execToUse.submit(
+ () -> {
+ final ReferenceCountingLock lock = createOrGetLock(segment);
Review comment:
@wjhypo can you add test for this runnable, travis is failing because of
code coverage issue. Once travis passes will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
