jihoonson opened a new pull request #12157:
URL: https://github.com/apache/druid/pull/12157
### Description
This PR fixes a bug that `DiscoveryDruidNode` cannot be created while
deserializing it from a JSON when there is an unknown `DruidService`. This bug
can be seen when you do rolling update. Suppose you have a custom
`MyDruidService` that is added in a new version, `v2`. While you are upgrading
your cluster from `v1` to `v2`, other nodes who watch the node that is upgraded
first and announces `MyDruidService` will not understand what `MyDruidService`
is until they are upgraded to `v2`. In this case, this bug currently can fail
node discovery. This PR fixes the bug by ignoring unknown `DruidServices`
during deserialization of `DiscoveryDruidNode`.
<hr>
##### Key changed/added classes in this PR
* `DiscoveryDruidNode`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
