FrankChen021 commented on a change in pull request #12157:
URL: https://github.com/apache/druid/pull/12157#discussion_r785661118
##########
File path:
server/src/main/java/org/apache/druid/discovery/DiscoveryDruidNode.java
##########
@@ -61,6 +73,28 @@ public DiscoveryDruidNode(
}
}
+ @JsonCreator
+ private static DiscoveryDruidNode fromJson(
+ @JsonProperty("druidNode") DruidNode druidNode,
+ @JsonProperty("nodeType") NodeRole nodeRole,
+ @JsonProperty("services") Map<String, Map<String, Object>> rawServices,
+ @JacksonInject ObjectMapper jsonMapper
+ )
+ {
+ Map<String, DruidService> services = new HashMap<>();
+ if (rawServices != null && !rawServices.isEmpty()) {
Review comment:
Oh, right. Maybe we can add some overridden methods to this util class
in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
