FrankChen021 commented on a change in pull request #12177:
URL: https://github.com/apache/druid/pull/12177#discussion_r788297662
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/parsers/JSONPathFieldSpec.java
##########
@@ -23,32 +23,55 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Preconditions;
+import java.util.List;
import java.util.Objects;
public class JSONPathFieldSpec
{
private final JSONPathFieldType type;
private final String name;
private final String expr;
+ private final List<String> exprs;
@JsonCreator
public JSONPathFieldSpec(
@JsonProperty("type") JSONPathFieldType type,
@JsonProperty("name") String name,
- @JsonProperty("expr") String expr
+ @JsonProperty("expr") String expr,
+ @JsonProperty("exprs") List<String> exprs
Review comment:
`exprs` and `expr` may be ambiguous. I think maybe we can name it as
`nodes` because node is a concept related to a tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
