kfaraz commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r796310048
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/Aggregator.java
##########
@@ -42,6 +42,12 @@
{
void aggregate();
+ default long aggregateWithSize()
Review comment:
> Should there be a warning that the default estimate is used?
It would make sense to give this warning when `factorizeWithSize` is
overridden but `aggregateWithSize` is not. In such a case, we might be
significantly underestimating the memory usage.
As you said, doing it here might be noisy. A viable approach could be to
have `factorizeWithSize` return a wrapper Aggregator which does not allow the
regular `aggregate` (will be addressed in the subsequent PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
