kfaraz commented on pull request #12073: URL: https://github.com/apache/druid/pull/12073#issuecomment-1014184047
> You should also document the approach that was finalized in the proposal and this implementation is based on. @abhishekagarwal87 , I have added an overview of the approach in `OnHeapIncrementalIndex`. I have also added javadocs for the methods in `Aggregator` and `AggregatorFactory`, but they contain information only relevant to those methods. Please let me know if this is sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
