paul-rogers opened a new pull request #12223: URL: https://github.com/apache/druid/pull/12223
### Description This is a super-simple PR to make unit testing just a bit less tedious. Unit test that set up a scan query frequently don't care about time, or want to query all time. Today, that requires hunting down the magic incantation and copy/paste it into the test. This PR adds a method, `eternity()` to the scan query builder to encapsulate that code to avoid the time spent hunting down an example (of which there seem to be three varieties.) The actual test that spurred this change is in another, more complex PR. To verify and illustrate the change, existing tests were changed to use the new method. Also include a small dose of code cleanup found along the way. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [X] been self-reviewed. - [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [X] been tested in a test Druid cluster as part of a wider set of changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
