abhishekagarwal87 commented on pull request #12163: URL: https://github.com/apache/druid/pull/12163#issuecomment-1031651741
Great work @LakshSingla. Almost there :) I had some comments on the error messages. My reasoning for the rephrasing is that users don't know about the conversion or translation of parameters they are passing. So if a parameter X cannot be converted to Y, the error message can simply be that "X is an invalid input. Please refer to documentation" instead of "Unable to convert X to Y". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
