LakshSingla commented on pull request #12163: URL: https://github.com/apache/druid/pull/12163#issuecomment-1031843598
Thanks @abhishekagarwal87 @gianm for another pass at the PR. I have updated the clumsy error messages in the DruidSqlParserUtils to be more affirmative, and hide the 'parse' that happens behind the scenes. Also, `DruidSqlInsert.unparse` now works as expected, updated the comment above with some examples for the same. Regarding `EXPLAIN PLAN FOR druidSqlInsert`, that would for sure be added in a separate PR, and shouldn't be much work once this gets merged. One of the reasons I wanted to raise a separate PR was because this patch contains a lot of boilerplate code to make the extended syntax work and I didn't want to incorporate those changes with this patch. I hope I have addressed the latest and the unresolved comments. PTAL at the updated PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
