clintropolis opened a new pull request #12244:
URL: https://github.com/apache/druid/pull/12244


   ### Description
   Split out bug fixes from #12241 in case that PR is too noisy. This PR fixes 
some issues uncovered while working on that other PR, related to null coercion 
with multi-value string array expressions, similar to the bugs fixed 
https://github.com/apache/druid/pull/12078 (and controlled by the flag 
https://github.com/apache/druid/pull/12210)
   
   This fix exists entirely within that other PR, though there is a subtle 
difference between the output of 
`CalciteMultiValueStringQueryTest.testMultiValueListFilterComposed` due to 
differences in behavior between the falllback `filter` expression and the 
native `ListFilteredVirtualColumn` (`filter` produces 0 length arrays for rows 
which do not match, while `ListFilteredVirtualColumn` considers these values as 
`null` which is consistent with the behavior of other multi-value string 
dimension selectors).
   
   Should the other PR be merged before this one, this can be closed (and 
likewise will fix up the other PR should this one be merged first).
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to