cryptoe commented on a change in pull request #12253:
URL: https://github.com/apache/druid/pull/12253#discussion_r804487958
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryEngine.java
##########
@@ -91,7 +91,13 @@ public GroupByQueryEngine(
"Null storage adapter found. Probably trying to issue a query
against a segment being memory unmapped."
);
}
-
+ if
(!query.getContextValue(GroupByQueryConfig.CTX_KEY_ENABLE_MULTI_VALUE_UNNESTING,
true)) {
+ throw new UnsupportedOperationException(String.format(
+ "GroupBy v1 does not support %s as false. Set %s to true",
Review comment:
Done
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByQueryEngineV2.java
##########
@@ -228,6 +228,17 @@ public GroupByEngineIterator make()
processingBuffer
);
+ final boolean allSingleValueDims =
hasNoExplodingDimensions(columnSelectorFactory,
+
query.getDimensions());
+ if
(!(query.getContextValue(GroupByQueryConfig.CTX_KEY_ENABLE_MULTI_VALUE_UNNESTING,
true))
+ && !allSingleValueDims) {
+ throw new ISE(
Review comment:
Acked. Agreed such messaging would be better for the users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
