clintropolis commented on a change in pull request #12253:
URL: https://github.com/apache/druid/pull/12253#discussion_r807563062
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByQueryEngineV2.java
##########
@@ -889,12 +911,17 @@ private void aggregateMultiValueDims(IntGrouper grouper)
}
while (!cursor.isDone()) {
- int multiValuesSize = multiValues.size();
+ final int multiValuesSize = multiValues.size();
if (multiValuesSize == 0) {
if
(!grouper.aggregate(GroupByColumnSelectorStrategy.GROUP_BY_MISSING_VALUE).isOk())
{
return;
}
} else {
+ if (multiValuesSize > 1) {
+ // this check is done during the row aggregation as a dimension
can become multi-value col if
+ // {@link org.apache.druid.segment.column.ColumnCapabilities} is
unkown.
Review comment:
nit: same nit and typo
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByQueryEngineV2.java
##########
@@ -764,6 +783,9 @@ protected void aggregateMultiValueDims(Grouper<ByteBuffer>
grouper)
);
if (doAggregate) {
+ // this check is done during the row aggregation as a dimension
can become multi-value col if
+ // {@link org.apache.druid.segment.column.ColumnCapabilities} is
unkown.
Review comment:
nit: javadoc links don't work here, maybe just say "column
capabilities", also "unkown" -> "unknown"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
