LakshSingla opened a new pull request #12259:
URL: https://github.com/apache/druid/pull/12259


   ### Description
   
   This PR aims to make the `ParseExceptions` in Druid more informative, by 
adding the input line number where the exception occurred, and the source which 
generated the exception. A `ParseException.Builder` is also added to make the 
creation of the `ParseException`s easier.
   
   This will also help in triaging the issues when `InputSourceReader` 
generates `ParseException`s because it can point to the specific `InputEntity` 
which caused the exception (while trying to read it). 
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `ParseException`
    * `InputEntityReader`'s subclasses
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to