jihoonson commented on a change in pull request #12250:
URL: https://github.com/apache/druid/pull/12250#discussion_r808380961
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionHandler.java
##########
@@ -116,6 +116,7 @@ DimensionMergerV9 makeMerger(
IndexSpec indexSpec,
SegmentWriteOutMedium segmentWriteOutMedium,
ColumnCapabilities capabilities,
+ boolean shouldStore,
Review comment:
I see what you describe and agree that could be cleaner as we can avoid
duplicate code blocks in each dimensionHandler. I'd like to do it as a
follow-up when I fix numeric dimensionHandlers if you are OK since currently
only the string dimensionHandler checks this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
