imply-cheddar commented on pull request #12250: URL: https://github.com/apache/druid/pull/12250#issuecomment-1042593807
Hrm, from my look at the code, most of the 104 files that were edited appear to have been edited because the feature flag was added as a top-level config. There's a ton of configs, it can get really, really confusing what all configs are needed versus not. If the intent of the feature flag is to build confidence in production, might I suggest a combination of a runtime config flag and context parameters instead? That should make it touch less parts of the code and hide the config that we would want to be deadedid in some future release anyway. Adding the config to the top-level object just creates another chunk of backwards compatibility work to try to remove it in the future. Given that this is much better semantics and that we hope this will just become default behavior, we shouldn't additionally bake in compatibility debt that we will have to work around later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
