jihoonson commented on a change in pull request #12263:
URL: https://github.com/apache/druid/pull/12263#discussion_r808568046
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -797,6 +800,29 @@ private void stopBeingLeader()
return ImmutableList.copyOf(duties);
}
+ private CompactSegments initializeCompactSegmentsDuty()
+ {
+ List<CompactSegments> compactSegmentsDutyFromCustomGroups =
getCompactSegmentsDutyFromCustomGroups();
+ if (compactSegmentsDutyFromCustomGroups.isEmpty()) {
+ return new CompactSegments(config, objectMapper, indexingServiceClient);
+ } else {
+ if (compactSegmentsDutyFromCustomGroups.size() > 1) {
+ log.warn("More than one compactSegments duty is configured in the
Coordinator Custom Duty Group");
Review comment:
```suggestion
log.warn("More than one compactSegments duty is configured in the
Coordinator Custom Duty Group. The first duty will be picked up.");
```
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java
##########
@@ -90,10 +92,11 @@
private final AtomicReference<Map<String, AutoCompactionSnapshot>>
autoCompactionSnapshotPerDataSource = new AtomicReference<>();
@Inject
+ @JsonCreator
Review comment:
Please add a serde test for this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
