samarthjain commented on pull request #12096: URL: https://github.com/apache/druid/pull/12096#issuecomment-1054602169
> HI @samarthjain @xvrl , I believe these comments have all been addressed in [a633c74](https://github.com/apache/druid/pull/12096/commits/a633c7447e69f407b58140b61f1d04ef6d078da4). I included a set of unit tests to confirm that any particular structure should be correctly read, so, I think this is good to go? Hi, @jasonk000 - sorry, it looks like I forgot publishing my review comments. They are mostly minor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
