clintropolis opened a new pull request #12291: URL: https://github.com/apache/druid/pull/12291
### Description This PR adds an additional optimization to `StringTopNColumnAggregatesProcessor`, the string processor used for heap based topN, for the case where a column is dictionary encoded, but not uniquely, and adds a cache of dictionaryId to `Aggregate[]` so avoid duplicate decoding of `utf8` bytes from the segment or recomputing expression virtual columns that occur on lookupName in some types of expression selectors. The existing topn tests should provide adequate coverage for this change, but will confirm this with the coverage bot once it runs in travis. This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
