abhishekagarwal87 commented on a change in pull request #12298:
URL: https://github.com/apache/druid/pull/12298#discussion_r818368946
##########
File path:
core/src/test/java/org/apache/druid/java/util/http/client/pool/ResourcePoolTest.java
##########
@@ -44,7 +44,8 @@ public void setUp()
EasyMock.replay(resourceFactory);
Review comment:
not comment on this line but we should also add tests when lazy
connection is set to true and verify that pool size increases when more
connections are requested.
##########
File path:
core/src/test/java/org/apache/druid/java/util/http/client/pool/ResourcePoolTest.java
##########
@@ -243,7 +244,8 @@ public void testTimedOutResource() throws Exception
pool = new ResourcePool<String, String>(
resourceFactory,
- new ResourcePoolConfig(2, TimeUnit.MILLISECONDS.toMillis(10))
+ new ResourcePoolConfig(2, TimeUnit.MILLISECONDS.toMillis(10)),
+ true
Review comment:
same comment here.
##########
File path:
core/src/test/java/org/apache/druid/java/util/http/client/pool/ResourcePoolTest.java
##########
@@ -44,7 +44,8 @@ public void setUp()
EasyMock.replay(resourceFactory);
pool = new ResourcePool<String, String>(
resourceFactory,
- new ResourcePoolConfig(2, TimeUnit.MINUTES.toMillis(4))
+ new ResourcePoolConfig(2, TimeUnit.MINUTES.toMillis(4)),
+ true
Review comment:
should this be false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
