AmatyaAvadhanula commented on a change in pull request #12298:
URL: https://github.com/apache/druid/pull/12298#discussion_r820666963
##########
File path:
core/src/main/java/org/apache/druid/java/util/http/client/pool/ResourcePool.java
##########
@@ -249,6 +302,7 @@ V get()
throw new RuntimeException(e);
}
+ numLentResources++;
Review comment:
numLentResources is not a direct substitute for maxSize -
resourceHolderList.size().
numLentResources + deficit contributes to that number. So it is intended to
increment it only after the change in deficit has been determined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
