clintropolis commented on a change in pull request #12320:
URL: https://github.com/apache/druid/pull/12320#discussion_r822208462
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/mean/DoubleMeanVectorAggregator.java
##########
@@ -44,8 +44,15 @@ public void init(final ByteBuffer buf, final int position)
@Override
public void aggregate(final ByteBuffer buf, final int position, final int
startRow, final int endRow)
{
+ final boolean[] nullVector = selector.getNullVector();
+
final double[] vector = selector.getDoubleVector();
for (int i = startRow; i < endRow; i++) {
+ if (nullVector != null) {
+ if (nullVector[i]) {
+ continue;
+ }
+ }
Review comment:
nit: might be worth having separate for loops for nullVector != null so
that we don't have to check if the value is null every loop iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
