FrankChen021 commented on a change in pull request #12316:
URL: https://github.com/apache/druid/pull/12316#discussion_r824810724
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/HumanReadableBytes.java
##########
@@ -227,7 +235,12 @@ private static long parseInner(String rawNumber)
* simplified SI format without 'B' indicator
* eg: K, M, G ...
*/
- DECIMAL
+ DECIMAL,
+ /**
+ * same as binary byte format, that k8s uses
+ * eg: Ki, Mi, Gi ...
+ */
+ KUBERNETES_BYTE
Review comment:
These enums are designed for the format function
`HUMAN_READABLE_XXXX_FORMAT` on SQL. At the SQL layer, since you don't add a
new SQL function, I think we don't need to add format support here. Another
reason is that I think at the SQL layer, it's better keeping the standard
format function only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
