churromorales commented on a change in pull request #12316:
URL: https://github.com/apache/druid/pull/12316#discussion_r826159532
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/HumanReadableBytes.java
##########
@@ -227,7 +235,12 @@ private static long parseInner(String rawNumber)
* simplified SI format without 'B' indicator
* eg: K, M, G ...
*/
- DECIMAL
+ DECIMAL,
+ /**
+ * same as binary byte format, that k8s uses
+ * eg: Ki, Mi, Gi ...
+ */
+ KUBERNETES_BYTE
Review comment:
yeah sure, ill remove this and corresponding tests. I didn't know if it
was used anywhere else from a config standpoint to do any conversion. But if
it is only for SQL better to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
