jihoonson opened a new pull request #12330:
URL: https://github.com/apache/druid/pull/12330
### Description
The `/tasks` API currently has a race condition since it sequentially
executes 2 queries against the metadata store, one to find 'complete' queries
and another to find 'active' queries. As a result, there could be a task that
is active while the first query is running but has been finished before the
second query starts. To fix the bug, this PR adds a new method in
`MetadataStorageActionHandler` that returns both active and complete tasks in
one transaction.
This PR also refactors `OverlordResource.getTasks()` as it is quite hard to
understand.
<hr>
##### Key changed/added classes in this PR
* `TaskLookup`
* `MetadataStorageActionHandler`
* `TaskStorage`
* `OverlordResource.getTasks`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
