rohangarg commented on a change in pull request #12326:
URL: https://github.com/apache/druid/pull/12326#discussion_r826084121
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java
##########
@@ -219,6 +219,24 @@ public TaskStatus call()
);
}
+ // Override task specific javaOptsArray
+ Object taskJavaOptsArray = task.getContextValue(
+ ForkingTaskRunnerConfig.JAVA_OPTS_ARRAY_PROPERTY
+ );
+ if (taskJavaOptsArray != null) {
+ if (taskJavaOptsArray instanceof List) {
Review comment:
instead of this - can we try `List<String> taskJavaOptsArray =
jsonMapper.convertValue(task.getContextValue(ForkingTaskRunnerConfig.JAVA_OPTS_ARRAY_PROPERTY),
new TypeReference<List<String>>() {});` and then add that whole array to the
command? Also, I think that we should throw an error incase of a bad format
instead of silently ignoring the overrides.
Please write a UT where the override (and hence setting) can be tested
between the deprecated prop and the new prop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
