cryptoe commented on a change in pull request #12248: URL: https://github.com/apache/druid/pull/12248#discussion_r827876910
########## File path: examples/quickstart/tutorial/hadoop/docker/Dockerfile ########## @@ -36,12 +36,22 @@ RUN ssh-keygen -q -N "" -t rsa -f /etc/ssh/ssh_host_rsa_key RUN ssh-keygen -q -N "" -t rsa -f /root/.ssh/id_rsa RUN cp /root/.ssh/id_rsa.pub /root/.ssh/authorized_keys -# zulu java 8 -COPY setup-zulu-repo.sh /root/setup-zulu-repo.sh -RUN /root/setup-zulu-repo.sh -RUN yum install -y zulu-8 +# +# Pull Zulu OpenJDK binaries from official repository: +# + +ARG ZULU_REPO_VER=1.0.0-1 + +RUN rpm --import http://repos.azulsystems.com/RPM-GPG-KEY-azulsystems && \ Review comment: this seems cleaner. You might want to update examples/quickstart/tutorial/hadoop3/docker/Dockerfle as well ? ########## File path: examples/quickstart/tutorial/hadoop/docker/Dockerfile ########## @@ -36,12 +36,22 @@ RUN ssh-keygen -q -N "" -t rsa -f /etc/ssh/ssh_host_rsa_key RUN ssh-keygen -q -N "" -t rsa -f /root/.ssh/id_rsa RUN cp /root/.ssh/id_rsa.pub /root/.ssh/authorized_keys -# zulu java 8 -COPY setup-zulu-repo.sh /root/setup-zulu-repo.sh -RUN /root/setup-zulu-repo.sh -RUN yum install -y zulu-8 +# +# Pull Zulu OpenJDK binaries from official repository: +# + +ARG ZULU_REPO_VER=1.0.0-1 + +RUN rpm --import http://repos.azulsystems.com/RPM-GPG-KEY-azulsystems && \ Review comment: This seems cleaner. You might want to update examples/quickstart/tutorial/hadoop3/docker/Dockerfle as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
