didip commented on a change in pull request #12340:
URL: https://github.com/apache/druid/pull/12340#discussion_r829173877



##########
File path: distribution/bin/generate-binary-notice.py
##########
@@ -57,7 +57,7 @@ def generate_notice(source_notice, dependences_yaml):
     # Print Apache license first.
     print_outfile(source_notice)
     with open(dependences_yaml, encoding='utf-8') as registry_file:
-        dependencies = list(yaml.load_all(registry_file))
+        dependencies = list(yaml.load_all(registry_file, Loader=yaml.Loader))

Review comment:
       @cryptoe Both pyyaml==5.4.1 and pyyaml==6.0.0 works on my hello world 
test.
   
   ```python
   import yaml
   print(yaml.load_all(open('hello.yaml', 'r'), Loader=yaml.Loader))
   ```
   

##########
File path: distribution/bin/generate-binary-notice.py
##########
@@ -57,7 +57,7 @@ def generate_notice(source_notice, dependences_yaml):
     # Print Apache license first.
     print_outfile(source_notice)
     with open(dependences_yaml, encoding='utf-8') as registry_file:
-        dependencies = list(yaml.load_all(registry_file))
+        dependencies = list(yaml.load_all(registry_file, Loader=yaml.Loader))

Review comment:
       @cryptoe Both pyyaml==5.4.1 and pyyaml==6.0.0 works on my hello world 
test.
   
   ```python
   import yaml
   print(yaml.load_all(open('licenses.yaml', 'r'), Loader=yaml.Loader))
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to