cryptoe commented on a change in pull request #12340:
URL: https://github.com/apache/druid/pull/12340#discussion_r830604298
##########
File path: distribution/bin/generate-binary-license.py
##########
@@ -102,7 +102,7 @@ def print_license(license):
license_phrase += "see {}".format(each_file)
else:
license_phrase += ", {}".format(each_file)
-
Review comment:
We generally try to avoid such changes.
##########
File path: pom.xml
##########
@@ -1835,6 +1835,8 @@
<exclude>.editorconfig</exclude>
<exclude>**/hadoop.indexer.libs.version</exclude>
<exclude>**/codegen/**</exclude>
+ <exclude>website/target/**</exclude>
Review comment:
As your py changes are not related to pom.xml, IMHO these changes are
not required.
If you think stuff is already broken in the master, please feel free to
raise a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
