kfaraz commented on code in PR #12397:
URL: https://github.com/apache/druid/pull/12397#discussion_r847960781
##########
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java:
##########
@@ -253,6 +259,11 @@ private void tryUpdateCache(String currentVersion) throws
Exception
throw t;
}
}
+ finally {
Review Comment:
Nit: @rohangarg , do you think it would be cleaner if we return the state of
`updatedCacheSuccessfully` from `tryUpdateCache` and use that value to update
the future `firstLoadFinishedSuccessfully` in `updateCache`.
I think it would help us avoid updating the future in both `updateCache` and
`tryUpdateCache`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
