suneet-s opened a new pull request, #12456:
URL: https://github.com/apache/druid/pull/12456
### Description
The SchemaStatsMonitor reports detailed metrics for each segment in the
cluster.
A user will need to enable this since I am not yet certain what the impact
will
be if this operation happens on large clusters.
The metric naming scheme of segment/detailed/* is because there are already
metrics named segment/* which have a similar use, but are reported
differently.
I had considered reporting the number of rows per segment via the
EmitClusterStatsAndMetricsModule since we have access to the DataSegment
object
in the coordinator when running through the details to decide which segments
need compaction. This proved challenging since the number of rows wasn't
readily available.
<hr>
This PR is still missing unit tests, but I was hoping to get an initial
round of feedback before I go too far down this path.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
