suneet-s commented on code in PR #12456: URL: https://github.com/apache/druid/pull/12456#discussion_r853108276
########## sql/src/main/java/org/apache/druid/sql/calcite/schema/SchemaStatsMonitor.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.schema; + +import org.apache.druid.java.util.emitter.service.ServiceEmitter; +import org.apache.druid.java.util.emitter.service.ServiceMetricEvent; +import org.apache.druid.java.util.metrics.AbstractMonitor; +import org.apache.druid.query.DruidMetrics; +import org.apache.druid.timeline.SegmentId; + +import javax.inject.Inject; +import java.util.Map; +import java.util.concurrent.ConcurrentSkipListMap; + +/** + * A monitor that provides stats on segments that are visible to the {@link DruidSchema} + */ +public class SchemaStatsMonitor extends AbstractMonitor Review Comment: I actually debated calling this `SegmentStatsMonitor`, but chose not to because the metrics are being emitted from the broker, which is not where I would expect a segment stats monitor to be. I thought that name would be confusing because as a user I would expect the SegmentStatsMonitor should be loadable in the historical since that's where all the segments are. With a name like `Schema...` I thought it would be more obvious that this should only be loaded in the broker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
