clintropolis commented on PR #12457: URL: https://github.com/apache/druid/pull/12457#issuecomment-1103274378
>How did you find these links? Is there a test already for stuff like this? Heh good question, something like a spidey sense I guess after I pressed approve if there were any sneaky things to consider. >Is there a test already for stuff like this? Sidebars isn't really testable because its controlling which things should be shown/hidden on the docs page nav sidebar, so is subjective. Spelling exceptions are not checked that the page they are referring to exists (though i'm unsure why we don't have just a giant exception list instead of that + per page exceptions...). Redirects could possibly be checked if we detect a diff that moves a doc page, but is currently not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
