suneet-s opened a new pull request, #12457: URL: https://github.com/apache/druid/pull/12457
### Description Move the stats-d emitter to a core extension. AFAICT we are using the latest version of the java client https://github.com/DataDog/java-dogstatsd-client/releases/tag/v4.0.0 I have tried running this extension in a cluster and haven't noticed any issues. I did notice that not all metrics are reported in the default configuration. I've added 2 more metrics to be reported by default `coordinator/global/time` and `coordinator/time` as these are helpful in knowing how long different coordinator duties are taking. I had considered a system to automatically detect when a new metric was reported so that we don't forget to update the config of this emitter when a new metric is added, however, I could not think of a reliable way to do this, so I decided to leave it out of the change that promotes this extension to a core extension. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
