liujianhuanzz commented on PR #12481: URL: https://github.com/apache/druid/pull/12481#issuecomment-1109260632
> I took a quick look at the implementation, there're two things we need to do: > > 1. [JvmMonitor: Handle more generation and collector scenarios. #12469](https://github.com/apache/druid/pull/12469) contains some changes that add the extra `--add-exports` JVM argument. We should remove these changes in this PR > 2. [JvmMonitor: Handle more generation and collector scenarios. #12469](https://github.com/apache/druid/pull/12469) and [Metrics for shenandoah #12369](https://github.com/apache/druid/pull/12369) added ZGC and Shenandoah, we should not forget adding support for these GC in this PR. For ZGC and Shenandoah, there is a problem: how to correspond to the young/old generation. In the current implementation - a ZGC generation variable is created - "Shenandoah Cycles" -> young - "Shenandoah Pauses" -> old -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
