adarshsanjeev commented on code in PR #12386: URL: https://github.com/apache/druid/pull/12386#discussion_r860505997
########## sql/src/main/java/org/apache/druid/sql/calcite/parser/DruidSqlReplace.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.parser; + +import com.google.common.base.Preconditions; +import org.apache.calcite.sql.SqlInsert; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.druid.java.util.common.granularity.Granularity; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +/** + * Extends the 'replace' call to hold custom parameters specific to Druid i.e. PARTITIONED BY and the PARTITION SPECS + * This class extends the {@link SqlInsert} so that this SqlNode can be used in + * {@link org.apache.calcite.sql2rel.SqlToRelConverter} for getting converted into RelNode, and further processing + */ +public class DruidSqlReplace extends SqlInsert +{ + public static final String SQL_REPLACE_TIME_CHUNKS = "sqlReplaceTimeChunks"; + + public static final SqlOperator OPERATOR = new SqlSpecialOperator("REPLACE", SqlKind.OTHER); + + private final Granularity partitionedBy; + private final String partitionedByStringForUnparse; + + private final SqlNode replaceTimeQuery; + + /** + * While partitionedBy and partitionedByStringForUnparse can be null as arguments to the constructor, this is + * disallowed (semantically) and the constructor performs checks to ensure that. This helps in producing friendly + * errors when the PARTITIONED BY custom clause is not present, and keeps its error separate from JavaCC/Calcite's + * custom errors which can be cryptic when someone accidentally forgets to explicitly specify the PARTITIONED BY clause + */ + public DruidSqlReplace( + @Nonnull SqlInsert insertNode, + @Nullable Granularity partitionedBy, + @Nullable String partitionedByStringForUnparse, + @Nonnull SqlNode replaceTimeQuery + ) throws ParseException + { + super( + insertNode.getParserPosition(), + (SqlNodeList) insertNode.getOperandList().get(0), // No better getter to extract this + insertNode.getTargetTable(), + insertNode.getSource(), + insertNode.getTargetColumnList() + ); + if (partitionedBy == null) { + throw new ParseException("REPLACE statements must specify PARTITIONED BY clause explictly"); + } + this.partitionedBy = partitionedBy; + + this.partitionedByStringForUnparse = Preconditions.checkNotNull(partitionedByStringForUnparse); + + this.replaceTimeQuery = replaceTimeQuery; + } + + public SqlNode getReplaceTimeQuery() + { + return replaceTimeQuery; + } + + public Granularity getPartitionedBy() + { + return partitionedBy; + } + + @Nonnull + @Override + public SqlOperator getOperator() + { + return OPERATOR; + } + + @Override + public void unparse(SqlWriter writer, int leftPrec, int rightPrec) Review Comment: Added a test for this method as well as the one in INSERT ########## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java: ########## @@ -761,84 +771,117 @@ public T next() private final SqlExplain explain; @Nullable - private final DruidSqlInsert insert; + private final SqlInsert insertOrReplace; private final SqlNode query; @Nullable private final Granularity ingestionGranularity; + @Nullable + private final List<String> replaceIntervals; + private ParsedNodes( @Nullable SqlExplain explain, - @Nullable DruidSqlInsert insert, + @Nullable SqlInsert insertOrReplace, SqlNode query, - @Nullable Granularity ingestionGranularity + @Nullable Granularity ingestionGranularity, + @Nullable List<String> replaceIntervals ) { this.explain = explain; - this.insert = insert; + this.insertOrReplace = insertOrReplace; this.query = query; this.ingestionGranularity = ingestionGranularity; + this.replaceIntervals = replaceIntervals; } - static ParsedNodes create(final SqlNode node) throws ValidationException + static ParsedNodes create(final SqlNode node, DateTimeZone dateTimeZone) throws ValidationException { SqlExplain explain = null; DruidSqlInsert druidSqlInsert = null; + DruidSqlReplace druidSqlReplace = null; SqlNode query = node; Granularity ingestionGranularity = null; + List<String> replaceIntervals = null; if (query.getKind() == SqlKind.EXPLAIN) { explain = (SqlExplain) query; query = explain.getExplicandum(); } if (query.getKind() == SqlKind.INSERT) { Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
