FrankChen021 opened a new pull request, #12501: URL: https://github.com/apache/druid/pull/12501
### Description This is a follow up of #12486 #12486 removes the web-console dependency from druid-server module because the dependency check reports that it's not used in druid-server module. Because druid-server module is referenced by many other modules, the existence of web-console dependency in druid-server module makes that module to be compiled after the web-console module. However, building of web-console module usually takes a long time. If the whole module is built in parallel with `-T` mvn parameter, this dependency makes the building slower. After #12486 is merged, @vogievetsky found that this dependency must be there or the web-console module won't be shipped in the distribution package(https://github.com/apache/druid/pull/12486#discussion_r863492827) The druid distribution package is packaged by the `mvn-assembly-plugin` referenced in the `druid-distribution` module. https://github.com/apache/druid/blob/0206a2da5c6211caf451751876d847f40c2e7755/distribution/pom.xml#L256-L258 This plugin is also configured to copy all dependencies declared in the pom of `druid-distribution` to the `lib` directory as below. https://github.com/apache/druid/blob/0206a2da5c6211caf451751876d847f40c2e7755/distribution/src/assembly/assembly.xml#L126-L129 So, we can move the dependency declaration from the druid-server module to the druid-distribution module so that we still gain the building speed up as well as the package integrity. Also, to prevent the missing of web-console in future, I added an IT case to check if the default home page of the web-console exists. This PR has: - [X] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [X] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
