paul-rogers commented on PR #12501: URL: https://github.com/apache/druid/pull/12501#issuecomment-1144256459
@FrankChen021, thanks for making this fix: the revised dependency looks right: it should be `distribution` that depends on the console, not some module which `distribution` depends on. That is, make the dependency direct, not transitive. Adding an IT is usually a Good Thing. There is, however, a big cost to adding a test group in the current setup: we build the entire Druid stack for each test group. I've been chipping away at [First cut at restructuring the integration tests](https://github.com/apache/druid/pull/12368) to make the ITs simpler and faster: your new test is a good candidate to port. In the mean while, can the IT be added to an existing group? It can just piggy-back on any one of the existing clusters, can't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
