loquisgon commented on code in PR #12488: URL: https://github.com/apache/druid/pull/12488#discussion_r870778242
########## docs/operations/metrics.md: ########## @@ -221,6 +221,41 @@ Note: If the JVM does not support CPU time measurement for the current thread, i |`worker/taskSlot/total/count`|Number of total task slots on the reporting worker per emission period. This metric is only available if the WorkerTaskCountStatsMonitor module is included.|category, version.|Varies.| |`worker/taskSlot/used/count`|Number of busy task slots on the reporting worker per emission period. This metric is only available if the WorkerTaskCountStatsMonitor module is included.|category, version.|Varies.| +## Batch ingestion metrics (Native parallel task) Review Comment: The `taskType` is already a dimension (i.e. for native batch types we have: `compact`, `index`, `index_parallel` and for streaming `index_kafka` , etc; for non native `index_hadoop`...) so yeah...maybe I should just drop the 'batch' (and `compact`) from the metric name and just use the `indexType` dimension to filter...is this what you are thinking @suneet-s ? ########## docs/operations/metrics.md: ########## @@ -221,6 +221,41 @@ Note: If the JVM does not support CPU time measurement for the current thread, i |`worker/taskSlot/total/count`|Number of total task slots on the reporting worker per emission period. This metric is only available if the WorkerTaskCountStatsMonitor module is included.|category, version.|Varies.| |`worker/taskSlot/used/count`|Number of busy task slots on the reporting worker per emission period. This metric is only available if the WorkerTaskCountStatsMonitor module is included.|category, version.|Varies.| +## Batch ingestion metrics (Native parallel task) Review Comment: The `taskType` is already a dimension (i.e. for native batch types we have: `compact`, `index`, `index_parallel` and for streaming `index_kafka` , etc; for non native `index_hadoop`...) so yeah...maybe I should just drop the `batch` (and `compact`) from the metric name and just use the `indexType` dimension to filter...is this what you are thinking @suneet-s ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
