zachjsh commented on code in PR #12488:
URL: https://github.com/apache/druid/pull/12488#discussion_r871592775
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -422,9 +423,32 @@ public boolean isPerfectRollup()
return tuningConfig != null && tuningConfig.isForceGuaranteedRollup();
}
+ @VisibleForTesting
+ void emitCompactIngestionModeMetrics(
+ ServiceEmitter emitter,
+ boolean isDropExisting
+ )
+ {
+
+ if (emitter == null) {
+ return;
+ }
+
+ // compact does not support appendToExisting
+ if (isDropExisting) {
+ emitter.emit(buildEvent("compact/replace/count", 1));
Review Comment:
Where are the dimensions set for this metric?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -422,9 +423,32 @@ public boolean isPerfectRollup()
return tuningConfig != null && tuningConfig.isForceGuaranteedRollup();
}
+ @VisibleForTesting
+ void emitCompactIngestionModeMetrics(
+ ServiceEmitter emitter,
+ boolean isDropExisting
+ )
+ {
+
+ if (emitter == null) {
+ return;
+ }
+
+ // compact does not support appendToExisting
+ if (isDropExisting) {
+ emitter.emit(buildEvent("compact/replace/count", 1));
Review Comment:
Where are the dimensions set for these metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
