abhishekagarwal87 commented on code in PR #12177:
URL: https://github.com/apache/druid/pull/12177#discussion_r873309186
##########
core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java:
##########
@@ -231,6 +235,11 @@ public Map<String, Object> toMap(T obj)
*/
Function<T, Object> makeJsonQueryExtractor(String expr);
+ /**
+ * Create a "field" extractor for nested json expressions
+ */
+ Function<T, Object> makeJsonTreeExtractor(List<String> nodes);
Review Comment:
@jasonk000 @FrankChen021 - this can potentially break extensions developed
outside apache repo. While the interface is not marked `ExtensionPoint`, it
does get extended outside the core. My suggestion will be to throw an
`UnsupportOperationException` in a default implementation. Also `getRootField`
needs to be called as before when `fieldSpec.getType()` returns `ROOT`.
what do you think?
##########
docs/ingestion/data-formats.md:
##########
@@ -254,11 +254,11 @@ To use the Parquet input format load the Druid Parquet
extension ([`druid-parque
Configure the Parquet `inputFormat` to load Parquet data as follows:
-| Field | Type | Description | Required |
-|-------|------|-------------|----------|
-|type| String| Set value to `parquet`.| yes |
-|flattenSpec| JSON Object | Define a [`flattenSpec`](#flattenspec) to extract
nested values from a Parquet file. Only 'path' expressions are supported ('jq'
is unavailable).| no (default will auto-discover 'root' level properties) |
-| binaryAsString | Boolean | Specifies if the bytes parquet column which is
not logically marked as a string or enum type should be treated as a UTF-8
encoded string. | no (default = false) |
+| Field | Type | Description
| Required |
+|-------|------|---------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|
+|type| String| Set value to `parquet`.
| yes |
+|flattenSpec| JSON Object | Define a [`flattenSpec`](#flattenspec) to extract
nested values from a Parquet file. Only 'path' expressions are supported ('jq'
and 'tree' are unavailable). | no (default will auto-discover 'root' level
properties) |
Review Comment:
can you a similar comment for ORC too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
