clintropolis commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r881209668
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -381,8 +386,12 @@ public static Comparable<?> convertObjectToType(
switch (type.getElementType().getType()) {
case STRING:
return convertToComparableStringArray(obj);
- default:
- return convertToList(obj);
+ case LONG:
+ return convertToListWithObjectFunction(obj,
CONVERT_OBJECT_TO_LONG_FUNCTION);
Review Comment:
nit: any reason not to use `DimensionHandlerUtils::convertObjectToLong`
instead of static fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
