a2l007 commented on PR #12408: URL: https://github.com/apache/druid/pull/12408#issuecomment-1138731044
> I think it is a mistake that it isn't `BSD-2-Clause License` on the right side of that line in `check-licenses.py` to homogenize it with the other forms of the 2 clause license. However, something is using `BSD 2-Clause License` in licenses.yaml, https://github.com/apache/druid/blob/master/licenses.yaml#L5031. > > I think the correct thing to do is change https://github.com/apache/druid/blob/master/distribution/bin/check-licenses.py#L236 to > > ``` > compatible_licenses['BSD 2-Clause license'] = 'BSD-2-Clause License' > ``` > > and update > > https://github.com/apache/druid/blob/master/licenses.yaml#L5031 to use `BSD-2-Clause License`. This makes sense, but since the license checker is throwing a KeyError: `KeyError: 'BSD 2-Clause License'`, shouldn't we add the following new key to compatible_licenses to fix this? ``` compatible_licenses['BSD 2-Clause License'] = 'BSD-2-Clause License' ``` Or we could modify the existing key from `BSD 2-Clause license` to `BSD 2-Clause License` since there aren't any dependencies that have this license identifier anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
