exherb commented on PR #12573: URL: https://github.com/apache/druid/pull/12573#issuecomment-1145510514
> Hey I looked at the change. The change itself is small but can have a large impact. > Can you please explain the statement : > `I think it's safe to convert the interval timezone to UTC, so getSequenceName will return the right sequence name instead of throw the exception.` > Is there a reason why you think so ? > It would be cool if you can add some ut's. Have a look at `PartialHashSegmentGenerateTaskTest#testCreateHashPartitionAnalysisFromPartitionsSpecWithNumShardsReturningAnalysisOfValidNumBuckets` Because it's just a local variable only as getSequenceName parameter. We have been use this patch in our product env, and successfully index segments from hour to day in Asia/Shanghai timezone. I will think a way to add some unit test to cover it. Thanks for your kindly reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
