kfaraz commented on code in PR #12624:
URL: https://github.com/apache/druid/pull/12624#discussion_r894230921
##########
server/src/test/java/org/apache/druid/server/coordinator/TestDruidCoordinatorConfig.java:
##########
@@ -252,4 +223,333 @@ public boolean getCoordinatorKillIgnoreDurationToRetain()
{
return coordinatorKillIgnoreDurationToRetain;
}
+
+ @Override
+ public String getLoadQueuePeonType()
+ {
+ return loadQueuePeonType;
+ }
+
+ @Override
+ public Duration getHttpLoadQueuePeonRepeatDelay()
+ {
+ return httpLoadQueuePeonRepeatDelay;
+ }
+
+ @Override
+ public int getNumCuratorCallBackThreads()
+ {
+ return curatorLoadQueuePeonNumCallbackThreads;
+ }
+
+ @Override
+ public Duration getHttpLoadQueuePeonHostTimeout()
+ {
+ return httpLoadQueuePeonHostTimeout;
+ }
+
+ @Override
+ public int getHttpLoadQueuePeonBatchSize()
+ {
+ return httpLoadQueuePeonBatchSize;
+ }
+
+ public static class Builder
+ {
+ private static final Duration DEFAULT_COORDINATOR_START_DELAY = new
Duration("PT300s");
+ private static final Duration DEFAULT_COORDINATOR_PERIOD = new
Duration("PT60s");
+ private static final Duration DEFAULT_COORDINATOR_INDEXING_PERIOD = new
Duration("PT1800s");
+ private static final Duration DEFAULT_METADATA_STORE_MANAGEMENT_PERIOD =
new Duration("PT3600s");
+ private static final Duration DEFAULT_COORDINATOR_KILL_PERIOD = new
Duration("PT86400s");
+ private static final Duration DEFAULT_COORDINATOR_KILL_DURATION_TO_RETAION
= new Duration("PT7776000s");
+ private static final boolean
DEFAULT_COORDINATOR_KILL_IGNORE_DURATION_TO_RETAIN = false;
+ private static final int DEFAULT_COORDINATOR_KILL_MAX_SEGMENTS = 100;
+ private static final Duration DEFAULT_COORDINATOR_SUPERVISOR_KILL_PERIOD =
new Duration("PT86400s");
+ private static final Duration
DEFAULT_COORDINATOR_SUPERVISOR_KILL_DURATION_TO_RETAIN = new
Duration("PT7776000s");
+ private static final Duration DEFAULT_COORDINATOR_COMPACTION_KILL_PERIOD =
new Duration("PT86400s");
+ private static final Duration DEFAULT_COORDINATOR_RULE_KILL_PERIOD = new
Duration("PT86400s");
+ private static final Duration
DEFAULT_COORDINATOR_RULE_KILL_DURATION_TO_RETAIN = new Duration("PT7776000s");
+ private static final Duration DEFAULT_COORDINATOR_DATASOURCE_KILL_PERIOD =
new Duration("PT86400s");
+ private static final Duration
DEFAULT_COORDINATOR_DATASOURCE_KILL_DURATION_TO_RETAIN = new
Duration("PT7776000s");
+ private static final Duration DEFAULT_LOAD_TIMEOUT_DELAY = new Duration(15
* 60 * 1000);
+ private static final Duration DEFAULT_LOAD_QUEUE_PEON_REPEAT_DELAY =
Duration.millis(50);
+ private static final String DEFAULT_LOAD_QUEUE_PEON_TYPE = "curator";
+ private static final int
DEFAULT_CURATOR_LOAD_QUEUE_PEON_NUM_CALLBACK_THREADS = 2;
+ private static final Duration DEFAULT_HTTP_LOAD_QUEUE_PEON_REPEAT_DELAY =
Duration.millis(60000);
+ private static final Duration DEFAULT_HTTP_LOAD_QUEUE_PEON_HOST_TIMEOUT =
Duration.millis(300000);
+ private static final int DEFAULT_HTTP_LOAD_QUEUE_PEON_BATCH_SIZE = 1;
+ private static final boolean DEFAULT_COMPACTION_SKIP_LOCKED_INTERVALS =
true;
+ private static final Duration DEFAULT_COORDINATOR_AUDIT_KILL_PERIOD = new
Duration("PT86400s");
+ private static final Duration
DEFAULT_COORDINATOR_AUTIT_KILL_DURATION_TO_RETAIN = new Duration("PT7776000s");
+
+
+ private Duration coordinatorStartDelay;
+ private Duration coordinatorPeriod;
+ private Duration coordinatorIndexingPeriod;
+ private Duration metadataStoreManagementPeriod;
+ private Duration coordinatorKillPeriod;
+ private Duration coordinatorKillDurationToRetain;
+ private Boolean coordinatorKillIgnoreDurationToRetain;
+ private Integer coordinatorKillMaxSegments;
+ private Duration coordinatorSupervisorKillPeriod;
+ private Duration coordinatorSupervisorKillDurationToRetain;
+ private Duration coordinatorCompactionKillPeriod;
+ private Duration coordinatorRuleKillPeriod;
+ private Duration coordinatorRuleKillDurationToRetain;
+ private Duration coordinatorDatasourceKillPeriod;
+ private Duration coordinatorDatasourceKillDurationToRetain;
+ private Duration loadTimeoutDelay;
+ private Duration loadQueuePeonRepeatDelay;
+ private String loadQueuePeonType;
+ private Duration httpLoadQueuePeonRepeatDelay;
+ private Integer curatorLoadQueuePeonNumCallbackThreads;
+ private Duration httpLoadQueuePeonHostTimeout;
+ private Integer httpLoadQueuePeonBatchSize;
+ private Boolean compactionSkippedLockedIntervals;
+ private Duration coordinatorAuditKillPeriod;
+ private Duration coordinatorAuditKillDurationToRetain;
+
+ public Builder()
+ {
+ }
+
+ public Builder(
+ Duration coordinatorStartDelay,
+ Duration coordinatorPeriod,
+ Duration coordinatorIndexingPeriod,
+ Duration metadataStoreManagementPeriod,
+ Duration coordinatorKillPeriod,
+ Duration coordinatorKillDurationToRetain,
+ Boolean coordinatorKillIgnoreDurationToRetain,
+ Integer coordinatorKillMaxSegments,
+ Duration coordinatorSupervisorKillPeriod,
+ Duration coordinatorSupervisorKillDurationToRetain,
+ Duration coordinatorCompactionKillPeriod,
+ Duration coordinatorRuleKillPeriod,
+ Duration coordinatorRuleKillDurationToRetain,
+ Duration coordinatorDatasourceKillPeriod,
+ Duration coordinatorDatasourceKillDurationToRetain,
+ Duration loadTimeoutDelay,
+ Duration loadQueuePeonRepeatDelay,
+ String loadQueuePeonType,
+ Duration httpLoadQueuePeonRepeatDelay,
+ Integer curatorLoadQueuePeonNumCallbackThreads,
+ Duration httpLoadQueuePeonHostTimeout,
+ Integer httpLoadQueuePeonBatchSize,
+ Boolean compactionSkippedLockedIntervals,
+ Duration coordinatorAuditKillPeriod,
+ Duration coordinatorAuditKillDurationToRetain
+ )
+ {
+ this.coordinatorStartDelay = coordinatorStartDelay;
+ this.coordinatorPeriod = coordinatorPeriod;
+ this.coordinatorIndexingPeriod = coordinatorIndexingPeriod;
+ this.metadataStoreManagementPeriod = metadataStoreManagementPeriod;
+ this.coordinatorKillPeriod = coordinatorKillPeriod;
+ this.coordinatorKillDurationToRetain = coordinatorKillDurationToRetain;
+ this.coordinatorKillIgnoreDurationToRetain =
coordinatorKillIgnoreDurationToRetain;
+ this.coordinatorKillMaxSegments = coordinatorKillMaxSegments;
+ this.coordinatorSupervisorKillPeriod = coordinatorSupervisorKillPeriod;
+ this.coordinatorSupervisorKillDurationToRetain =
coordinatorSupervisorKillDurationToRetain;
+ this.coordinatorCompactionKillPeriod = coordinatorCompactionKillPeriod;
+ this.coordinatorRuleKillPeriod = coordinatorRuleKillPeriod;
+ this.coordinatorRuleKillDurationToRetain =
coordinatorRuleKillDurationToRetain;
+ this.coordinatorDatasourceKillPeriod = coordinatorDatasourceKillPeriod;
+ this.coordinatorDatasourceKillDurationToRetain =
coordinatorDatasourceKillDurationToRetain;
+ this.loadTimeoutDelay = loadTimeoutDelay;
+ this.loadQueuePeonRepeatDelay = loadQueuePeonRepeatDelay;
+ this.loadQueuePeonType = loadQueuePeonType;
+ this.httpLoadQueuePeonRepeatDelay = httpLoadQueuePeonRepeatDelay;
+ this.curatorLoadQueuePeonNumCallbackThreads =
curatorLoadQueuePeonNumCallbackThreads;
+ this.httpLoadQueuePeonHostTimeout = httpLoadQueuePeonHostTimeout;
+ this.httpLoadQueuePeonBatchSize = httpLoadQueuePeonBatchSize;
+ this.compactionSkippedLockedIntervals = compactionSkippedLockedIntervals;
+ this.coordinatorAuditKillPeriod = coordinatorAuditKillPeriod;
+ this.coordinatorAuditKillDurationToRetain =
coordinatorAuditKillDurationToRetain;
+ }
+
+ public Builder withCoordinatorStartDelay(Duration coordinatorStartDelay)
+ {
+ this.coordinatorStartDelay = coordinatorStartDelay;
+ return this;
+ }
+
+ public Builder withCoordinatorPeriod(Duration coordinatorPeriod)
+ {
+ this.coordinatorPeriod = coordinatorPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorIndexingPeriod(Duration
coordinatorIndexingPeriod)
+ {
+ this.coordinatorIndexingPeriod = coordinatorIndexingPeriod;
+ return this;
+ }
+
+ public Builder withMetadataStoreManagementPeriod(Duration
metadataStoreManagementPeriod)
+ {
+ this.metadataStoreManagementPeriod = metadataStoreManagementPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorKillPeriod(Duration coordinatorKillPeriod)
+ {
+ this.coordinatorKillPeriod = coordinatorKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorKillDurationToRetain(Duration
coordinatorKillDurationToRetain)
+ {
+ this.coordinatorKillDurationToRetain = coordinatorKillDurationToRetain;
+ return this;
+ }
+
+ public Builder withCoordinatorKillIgnoreDurationToRetain(boolean
coordinatorKillIgnoreDurationToRetain)
+ {
+ this.coordinatorKillIgnoreDurationToRetain =
coordinatorKillIgnoreDurationToRetain;
+ return this;
+ }
+
+ public Builder withCoordinatorKillMaxSegments(int
coordinatorKillMaxSegments)
+ {
+ this.coordinatorKillMaxSegments = coordinatorKillMaxSegments;
+ return this;
+ }
+
+ public Builder withCoordinatorSupervisorKillPeriod(Duration
coordinatorSupervisorKillPeriod)
+ {
+ this.coordinatorSupervisorKillPeriod = coordinatorSupervisorKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorSupervisorKillDurationToRetain(Duration
coordinatorSupervisorKillDurationToRetain)
+ {
+ this.coordinatorSupervisorKillDurationToRetain =
coordinatorSupervisorKillDurationToRetain;
+ return this;
+ }
+
+ public Builder withCoordinatorCompactionKillPeriod(Duration
coordinatorCompactionKillPeriod)
+ {
+ this.coordinatorCompactionKillPeriod = coordinatorCompactionKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorRuleKillPeriod(Duration
coordinatorRuleKillPeriod)
+ {
+ this.coordinatorRuleKillPeriod = coordinatorRuleKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorRuleKillDurationToRetain(Duration
coordinatorRuleKillDurationToRetain)
+ {
+ this.coordinatorRuleKillDurationToRetain =
coordinatorRuleKillDurationToRetain;
+ return this;
+ }
+
+ public Builder withCoordinatorDatasourceKillPeriod(Duration
coordinatorDatasourceKillPeriod)
+ {
+ this.coordinatorDatasourceKillPeriod = coordinatorDatasourceKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorDatasourceKillDurationToRetain(Duration
coordinatorDatasourceKillDurationToRetain)
+ {
+ this.coordinatorDatasourceKillDurationToRetain =
coordinatorDatasourceKillDurationToRetain;
+ return this;
+ }
+
+ public Builder withLoadTimeoutDelay(Duration loadTimeoutDelay)
+ {
+ this.loadTimeoutDelay = loadTimeoutDelay;
+ return this;
+ }
+
+ public Builder withLoadQueuePeonRepeatDelay(Duration
loadQueuePeonRepeatDelay)
+ {
+ this.loadQueuePeonRepeatDelay = loadQueuePeonRepeatDelay;
+ return this;
+ }
+
+ public Builder withLoadQueuePeonType(String loadQueuePeonType)
+ {
+ this.loadQueuePeonType = loadQueuePeonType;
+ return this;
+ }
+
+ public Builder withHttpLoadQueuePeonRepeatDelay(Duration
httpLoadQueuePeonRepeatDelay)
+ {
+ this.httpLoadQueuePeonRepeatDelay = httpLoadQueuePeonRepeatDelay;
+ return this;
+ }
+
+ public Builder withCuratorLoadQueuePeonNumCallbackThreads(int
curatorLoadQueuePeonNumCallbackThreads)
+ {
+ this.curatorLoadQueuePeonNumCallbackThreads =
curatorLoadQueuePeonNumCallbackThreads;
+ return this;
+ }
+
+ public Builder withHttpLoadQueuePeonHostTimeout(Duration
withHttploadQueuePeonHostTimeout)
+ {
+ this.httpLoadQueuePeonHostTimeout = httpLoadQueuePeonHostTimeout;
+ return this;
+ }
+
+ public Builder withHttpLoadQueuePeonBatchSize(int
httpLoadQueuePeonBatchSize)
+ {
+ this.httpLoadQueuePeonBatchSize = httpLoadQueuePeonBatchSize;
+ return this;
+ }
+
+ public Builder withCompactionSkippedLockedIntervals(boolean
compactionSkippedLockedIntervals)
+ {
+ this.compactionSkippedLockedIntervals = compactionSkippedLockedIntervals;
+ return this;
+ }
+
+ public Builder withCoordianatorAuditKillPeriod(Duration
coordinatorAuditKillPeriod)
+ {
+ this.coordinatorAuditKillPeriod = coordinatorAuditKillPeriod;
+ return this;
+ }
+
+ public Builder withCoordinatorAuditKillDurationToRetain(Duration
coordinatorAuditKillDurationToRetain)
+ {
+ this.coordinatorAuditKillDurationToRetain =
coordinatorAuditKillDurationToRetain;
+ return this;
+ }
+
+ //TODO add mising fields to both TEst and builder.build investigate
loadTimeoutDelay naming in Test. Migrate usage to builder.
Review Comment:
Unresolved TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
