clintropolis commented on code in PR #12627:
URL: https://github.com/apache/druid/pull/12627#discussion_r895112203
##########
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedStringIndexSupplier.java:
##########
@@ -77,42 +78,45 @@ public DictionaryEncodedStringIndexSupplier(
this.dictionaryUtf8 = dictionaryUtf8;
this.bitmaps = bitmaps;
this.indexedTree = indexedTree;
+ this.zeroIsNull = NullHandling.isNullOrEquivalent(dictionary.get(0));
Review Comment:
it didn't seem that expensive to just do this when we need it, so i just
moved this into `as` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
