gianm commented on code in PR #12763: URL: https://github.com/apache/druid/pull/12763#discussion_r917570413
########## processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java: ########## @@ -43,12 +48,14 @@ private static final String CTX_KEY_BUFFER_GROUPER_MAX_LOAD_FACTOR = "bufferGrouperMaxLoadFactor"; private static final String CTX_KEY_BUFFER_GROUPER_MAX_SIZE = "bufferGrouperMaxSize"; private static final String CTX_KEY_MAX_ON_DISK_STORAGE = "maxOnDiskStorage"; - private static final String CTX_KEY_MAX_SELECTOR_DICTIONARY_SIZE = "maxSelectorDictionarySize"; - private static final String CTX_KEY_MAX_MERGING_DICTIONARY_SIZE = "maxMergingDictionarySize"; private static final String CTX_KEY_FORCE_HASH_AGGREGATION = "forceHashAggregation"; private static final String CTX_KEY_INTERMEDIATE_COMBINE_DEGREE = "intermediateCombineDegree"; private static final String CTX_KEY_NUM_PARALLEL_COMBINE_THREADS = "numParallelCombineThreads"; private static final String CTX_KEY_MERGE_THREAD_LOCAL = "mergeThreadLocal"; + private static final double MERGING_DICTIONARY_HEAP_FRACTION = 0.3; + private static final double SELECTOR_DICTIONARY_HEAP_FRACTION = 0.10; + private static final long MIN_AUTOMATIC_DICTIONARY_SIZE = 1_000_000; + private static final long MAX_AUTOMATIC_DICTIONARY_SIZE = 1_000_000_000; Review Comment: Hmm. Why is it less confusing to use 1GiB instead of 1GB? As one data point, the old default (100MB) was in decimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
