LakshSingla opened a new pull request, #12770:
URL: https://github.com/apache/druid/pull/12770
### Description
Queries like
```
REPLACE INTO inline_data1 OVERWRITE ALL
SELECT
TIME_PARSE("__time") AS __time
FROM TABLE(
EXTERN(
'{"type":"inline","data":"{\"__time\":\"2022-02-02T02:02:02.002\"}"}',
'{"type":"json"}',
'[{"name":"__time","type":"string"}]'
)
)
PARTITIONED BY ALL
```
would fail at the Calcite layer. This is because any column with name __time
is considered to be of type `SqlTypeName.TIMESTAMP`
([code](https://github.com/apache/druid/blob/cebf2ba9c79df12c214364380ccb53207776e34e/sql/src/main/java/org/apache/druid/sql/calcite/table/RowSignatures.java#L99))
without consideration for the type that is getting passed in `EXTERN`. This
messes up functions like TIME_PARSE which are expected to work with a certain
signature.
This PR aims to restrict `EXTERN` inputs with column names having `__time`
column of type other than long.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
