LakshSingla commented on PR #12770: URL: https://github.com/apache/druid/pull/12770#issuecomment-1192453319
Reverted the PR to prevent using `__time` column with type other than `LONG`. Simultaneously, I am also preventing typecasting of data to SqlTypeName.TIMESTAMP when passed in `EXTERN`. 1. The reason for the restriction is that currently [RowBasedColumnSelectorFactory](https://github.com/apache/druid/blob/9e5f0109fd00ffbed2ee80ebb0dfae253660ed5f/processing/src/main/java/org/apache/druid/segment/RowBasedColumnSelectorFactory.java#L123) typecasts the `__time` column to LONG irrespective of data type which causes erroneous evaluations of the expressions and the column. 2. I have decided to keep in the typecasting changes because that seems logical for the Calcite layer, i.e. to go with whatever type has been explicitly mentioned by the user. One advantage of this is that LONG won't get typecasted to TIMESTAMP and functions that operate on LONG won't get affected (which was not the case with the original commit in this PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
