imply-cheddar opened a new pull request, #12828: URL: https://github.com/apache/druid/pull/12828
The Avro parsing code leaks some "object" representations. We need to convert them into Maps/Lists so that other code can understand and expect good things. Previously, these objects were handled with .toString(), but that's not a good contract in terms of how to work with objects. That said, this does potentially introduce a chance for "backwards incompatibility" because anybody who happened to actually have these objects "leak" into their ingestion would have ended up with these objects being stored as a String column with a value as the .toString(). When they update to this new code, they will still have a String column, but it will be the String returned from `Map.toString()` instead of the `GenericRecord.toString`. So, the actual content would be slightly different. Relying on this behavior is... questionable at best. If someone is actually relying on this, then they can have the option of grabbing the avro extension from a previous version and continuing to use that instead of using this updated version. In terms of the behavior expected out-of-the-box from the code, the behavior that this change creates is significantly better. So, given that depending on the previous behavior is likely to be low value anyway *and* that there is a meaningful workaround in that you can choose to use the old extension jar instead, we should accept the compatibility change and make forward progress. This PR has: - [x] been self-reviewed. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
